Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #6481 #6484

Merged
merged 4 commits into from
Jul 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 34 additions & 34 deletions go/vt/vtctld/rice-box.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tools/web_bootstrap.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

# Copyright 2019 The Vitess Authors.
# Copyright 2020 The Vitess Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion tools/web_build.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

# Copyright 2019 The Vitess Authors.
# Copyright 2020 The Vitess Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion web/vtctld2/app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@
</head>
<body class="flex-column">
<vt-app-root class="flex-column flex-grow">Loading...</vt-app-root>
<script type="text/javascript" src="inline.js"></script><script type="text/javascript" src="styles.38b88af69dfd283498eb.bundle.js"></script><script type="text/javascript" src="main.3a2141f06032f2bc1229.bundle.js"></script></body>
<script type="text/javascript" src="inline.js"></script><script type="text/javascript" src="styles.38b88af69dfd283498eb.bundle.js"></script><script type="text/javascript" src="main.9a3d6a925af135b7c609.bundle.js"></script></body>
</html>
2 changes: 1 addition & 1 deletion web/vtctld2/app/inline.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Binary file not shown.
20 changes: 10 additions & 10 deletions web/vtctld2/src/app/dashboard/shard.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ export class ShardComponent implements OnInit, OnDestroy {
if (!isMaster) {
// Add replication-related methods to the 'Change' section for slaves.
result[1].items.push(
{label: 'Start Slave', command: (event) => {this.openStartSlaveDialog(); }},
{label: 'Stop Slave', command: (event) => {this.openStopSlaveDialog(); }},
{label: 'Start Replication', command: (event) => {this.openStartSlaveDialog(); }},
{label: 'Stop Replication', command: (event) => {this.openStopSlaveDialog(); }},
);
}
if (this.featuresService.activeReparents) {
Expand Down Expand Up @@ -490,20 +490,20 @@ export class ShardComponent implements OnInit, OnDestroy {
}

openStartSlaveDialog() {
this.dialogSettings = new DialogSettings('Start', `Start Slave on ${this.selectedTablet.label}`,
`Restart replication on slave ${this.selectedTablet.label}.`,
`There was a problem starting slave on ${this.selectedTablet.label}:`);
this.dialogSettings.setMessage(`Started Slave on ${this.selectedTablet.label}`);
this.dialogSettings = new DialogSettings('Start', `Start replication on ${this.selectedTablet.label}`,
`Restart replication on ${this.selectedTablet.label}.`,
`There was a problem starting replication on ${this.selectedTablet.label}:`);
this.dialogSettings.setMessage(`Started replication on ${this.selectedTablet.label}`);
let flags = new PingTabletFlags(this.selectedTablet.alias).flags;
this.dialogContent = new DialogContent('tablet_alias', flags, {}, undefined, 'StartSlave');
this.dialogSettings.toggleModal();
}

openStopSlaveDialog() {
this.dialogSettings = new DialogSettings('Stop', `Stop Slave on ${this.selectedTablet.label}`,
`Stop replication on slave ${this.selectedTablet.label}. May render the tablet unhealthy.`,
`There was a problem stopping slave on ${this.selectedTablet.label}:`);
this.dialogSettings.setMessage(`Stopped Slave on ${this.selectedTablet.label}`);
this.dialogSettings = new DialogSettings('Stop', `Stop replication on ${this.selectedTablet.label}`,
`Stop replication on ${this.selectedTablet.label}. May render the tablet unhealthy.`,
`There was a problem stopping replication on ${this.selectedTablet.label}:`);
this.dialogSettings.setMessage(`Stopped replication on ${this.selectedTablet.label}`);
let flags = new PingTabletFlags(this.selectedTablet.alias).flags;
this.dialogContent = new DialogContent('tablet_alias', flags, {}, undefined, 'StopSlave');
this.dialogSettings.toggleModal();
Expand Down
12 changes: 6 additions & 6 deletions web/vtctld2/src/app/dashboard/tablet.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,19 +116,19 @@ export class TabletComponent implements OnInit, OnDestroy {
}

openStartSlaveDialog() {
this.dialogSettings = new DialogSettings('Start', `Start Slave, ${this.tablet.label}`, '',
`There was a problem starting slave, ${this.tablet.label}:`);
this.dialogSettings.setMessage(`Started Slave, ${this.tablet.label}`);
this.dialogSettings = new DialogSettings('Start', `Start Replication, ${this.tablet.label}`, '',
`There was a problem starting replication on, ${this.tablet.label}:`);
this.dialogSettings.setMessage(`Started Replication, ${this.tablet.label}`);
this.dialogSettings.onCloseFunction = this.refreshTabletView.bind(this);
let flags = new PingTabletFlags(this.tablet.ref).flags;
this.dialogContent = new DialogContent('tablet_alias', flags, {}, undefined, 'StartSlave');
this.dialogSettings.toggleModal();
}

openStopSlaveDialog() {
this.dialogSettings = new DialogSettings('Stop', `Stop Slave, ${this.tablet.label}`, '',
`There was a problem stopping slave, ${this.tablet.label}:`);
this.dialogSettings.setMessage(`Stopped Slave, ${this.tablet.label}`);
this.dialogSettings = new DialogSettings('Stop', `Stop Replication, ${this.tablet.label}`, '',
`There was a problem stopping replication on, ${this.tablet.label}:`);
this.dialogSettings.setMessage(`Stopped Replication, ${this.tablet.label}`);
this.dialogSettings.onCloseFunction = this.refreshTabletView.bind(this);
let flags = new PingTabletFlags(this.tablet.ref).flags;
this.dialogContent = new DialogContent('tablet_alias', flags, {}, undefined, 'StopSlave');
Expand Down