Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Savepoint Construct Implementation in VTGate #6414

Merged
merged 9 commits into from
Jul 13, 2020
Merged

Savepoint Construct Implementation in VTGate #6414

merged 9 commits into from
Jul 13, 2020

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Jul 6, 2020 •
edited
Loading

Savepoint implementation in VTGate.

sougou
sougou reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need more test cases. The one I was looking for is the one that sends prequeries for BeginExecute.

@harshit-gangal
added savepoint constructs planning support
6074be5 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
savepoint constructs execution implementation
ad58a95 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
allow savepoint only if shard session exists
9e18a23 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
savepoint: modified savepoint test
52c229a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added savepoint in session
cbea46c 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
savepoint: use session to store savepoints and pass on beginExecute
820c56e 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
savepoint: added additional end to end test case
3e935a9 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
savepoint: addressed review comments
ce85483 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal requested a review from sougou July 9, 2020 20:29
@harshit-gangal
savepoint: added unit test
44f144f 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal mentioned this pull request Jul 12, 2020
Merged
@sougou sougou merged commit a83aaee into vitessio:master Jul 13, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
@deepthi deepthi mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-gangal @sougou @deepthi