Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how tracing information is deserialised #6398

Closed
wants to merge 1 commit into from
Closed

Change how tracing information is deserialised #6398

wants to merge 1 commit into from

Conversation

systay
Copy link
Collaborator

@systay systay commented Jun 30, 2020

No description provided.

@systay systay requested a review from sougou as a code owner June 30, 2020 13:58
@systay systay mentioned this pull request Jun 30, 2020
Closed
@systay systay requested review from arka-g and harshit-gangal June 30, 2020 14:00
@systay
Change how tracing information is deserialized
4f4e96a 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@deepthi
Copy link
Member

deepthi commented Jun 30, 2020

@systay @arka-g can one of you document why this change is needed? either as an issue or in the PR description itself.

sougou
sougou reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we parsing html headers here? If so, could we use an existing API?
Who creates these strings, and where's the code that creates it?

@systay systay closed this Jul 1, 2020
@systay
Copy link
Collaborator Author

systay commented Jul 1, 2020

This is not a good solution. Will re-open a new PR with a better approach.

@systay systay reopened this Jul 1, 2020
@systay systay closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou left review comments

@arka-g arka-g Awaiting requested review from arka-g

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

Assignees
No one assigned
Labels
Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@systay @deepthi @sougou