Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to slave where possible #6379

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Remove references to slave where possible #6379

merged 1 commit into from
Jun 25, 2020

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Jun 25, 2020

There was one mysql setting called slave_load_tmp_dir which I removed. This appears to no longer be in MySQL; I forget the context, but Vitess requires RBR anyway, which means LOAD DATA events do not need a tmpdir.

Signed-off-by: Morgan Tocker tocker@gmail.com

@morgo
Remove references to slave where possible
917eda5 
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo requested a review from sougou as a code owner June 25, 2020 14:56
deepthi
deepthi approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepthi deepthi merged commit a17a454 into vitessio:master Jun 25, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morgo @deepthi