Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support locking functions #6370

Merged
merged 15 commits into from
Jul 24, 2020
Merged

Support locking functions #6370

merged 15 commits into from
Jul 24, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Jun 24, 2020 •
edited by harshit-gangal
Loading

Closes: #6367

@harshit-gangal harshit-gangal force-pushed the get_lock branch 6 times, most recently from 03d27bc to 2d80db6 Compare July 18, 2020 16:15
@harshit-gangal harshit-gangal force-pushed the get_lock branch 2 times, most recently from 0f04e8a to 8697c5d Compare July 19, 2020 19:15
@harshit-gangal harshit-gangal requested review from deepthi and sougou July 20, 2020 03:45
@harshit-gangal harshit-gangal marked this pull request as ready for review July 20, 2020 21:07
@harshit-gangal harshit-gangal mentioned this pull request Jul 20, 2020
Merged
systay and others added 13 commits July 24, 2020 10:47
@systay @harshit-gangal
get-lock: update list of locking functions
fbd8287 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
get-lock: start of planning
aa77b29 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
allow pool unsafe statement on reserved connections
bd50ffd 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
updated lock func planning
9fd831a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added lock func unit test
88e64ac 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay @harshit-gangal
more testing around locking functions
c5b4289 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
added tx and lock related endtoend test
44112ca 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added firstSortedKeyspace method and additional lock unit test
a8e0384 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay @harshit-gangal
fail connections trying to use reserved connections on the legacy hea…
9ed5b59 
…lth check

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
update tests to use the new healthcheck
1dbda7d 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
updated test assertions
919bf83 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
use the new gateway for end to end tests
fa083ba 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
tabletgateway.withRetry should allow master transactions
7602ee1 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
fix unit test after master merge due to change in parameter list
007b73d 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
cell_alias e2e test to use legacy gateway
316090d 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit b9b5e0b into vitessio:master Jul 24, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@harshit-gangal harshit-gangal harshit-gangal left review comments

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.

RFC: Locking functions
4 participants
@systay @deepthi @sougou @harshit-gangal