SIGHUP support for tls config update #6215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huiqing <hzhou@pinterest.com>
sougou
reviewed
May 24, 2020
There was a problem hiding this comment.
Change looks good. Would it be possible to write a hup test to show that it works? Something like this https://github.com/vitessio/vitess/blob/master/go/mysql/auth_server_static_test.go#L130
Signed-off-by: huiqing <hzhou@pinterest.com>
Thanks a lot Sugu, i've refactored it a bit to make the SIGHUP unit test easier. |
sougou
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to tablet config and mysql auth config, at pinterest, we need some mechanism to update the
tls configand would like to use the sameSIGHUPapproach.