Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to test multiple endpoints with aya #6202

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

sverch
Copy link
Contributor

@sverch sverch commented May 19, 2020

This cleans up the interface of are you alive to pass it a config file with endpoint configuration rather than command line options that make are you alive construct the connection strings in different ways.

This makes it easier to test a larger number of endpoints, so that, for example, you could easily configure it to write to one endpoint while reading from 11 others, at any rate you want.

Also removes environment from the labels since that could be added later by the deployment, and makes the rate configuration a true rate instead of a delay.

@sverch sverch requested a review from sougou as a code owner May 19, 2020 21:56
This cleans up the interface of are you alive to pass it a config file
with endpoint configuration rather than command line options that make
are you alive construct the connection strings in different ways.

This makes it easier to test a larger number of endpoints, so that, for
example, you could easily configure it to write to one endpoint while
reading from 11 others, at any rate you want.

Also removes environment from the labels since that could be added later
by the deployment, and makes the rate configuration a true rate instead
of a delay.

Signed-off-by: Shaun Verch <sverch@planetscale.com>
@sverch sverch force-pushed the are-you-alive-multicloud branch from c5d230b to 0b63bcd Compare May 19, 2020 21:57
Signed-off-by: Shaun Verch <sverch@planetscale.com>
@sougou sougou requested a review from morgo May 24, 2020 04:05
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit bfd2ac4 into vitessio:master Jun 23, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants