Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support drop vindex #6151

Merged
merged 1 commit into from
May 10, 2020
Merged

support drop vindex #6151

merged 1 commit into from
May 10, 2020

Conversation

inolddays
Copy link
Contributor

support:
alter vschema drop vindex xxx;
Signed-off-by: JohnnyThree whereshallyoube@gmail.com

@inolddays inolddays requested a review from sougou as a code owner May 6, 2020 11:21
harshit-gangal
harshit-gangal reviewed May 6, 2020
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to add test for them.

@inolddays
support drop vindex
44f9e9a 
Signed-off-by: JohnnyThree <whereshallyoube@gmail.com>
@inolddays inolddays force-pushed the supportdropvindexstr branch from e6dbdc2 to 44f9e9a Compare May 7, 2020 09:25
@inolddays
Copy link
Contributor Author

You would need to add test for them.

done

@harshit-gangal harshit-gangal merged commit 4298dd0 into vitessio:master May 10, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@inolddays @harshit-gangal @deepthi