Add new debug handlers to set block and mutex profiling #6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that actually useful pprof for block and mutex can be extracted from a running vtgate. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
sougou
reviewed
May 1, 2020
There was a problem hiding this comment.
Could you move this to servenv/status.go? Then you can add a link to these URLs here: https://github.com/vitessio/vitess/blob/master/go/vt/servenv/status.go#L110-L111, and also default them to 100% coverage. This will benefit all our binaries.
If it gets too complicated, let me know, we can push this through and move it later.
This will allow us to debug all vitess servers. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
UI, we should make it toggles, and mark it appropriately to alert users to the fact that it can be dangerous from a performance impact p.o.v. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
sougou
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that actually useful pprof for block and mutex can be extracted from a
running vtgate.
Use this by calling something like http://localhost:15001/debug/blockprofilerate?rate=1 (for 100% blocking coverage) and http://localhost:15001/debug/mutexprofilefraction?fraction=1 (for 100% mutex coverage)
Signed-off-by: Jacques Grove aquarapid@gmail.com
EDIT: The final implementation supports this for all vitess binaries.