Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of packets sent from vttablet to MySQL #6130

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

keyurdg
Copy link
Contributor

@keyurdg keyurdg commented Apr 29, 2020

Create the write buffers with pre-allocated space for the header as well.

Signed-off-by: Keyur Govande keyur_govande@yahoo.com

using TCP by creating the write buffers with pre-allocated space
for the header.

Signed-off-by: Keyur Govande <keyur_govande@yahoo.com>
@keyurdg keyurdg requested a review from sougou as a code owner April 29, 2020 05:13
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I would have personally considered thrashing the buffer in favor of simplicity, but no harm preserving the original bytes.

@sougou sougou merged commit 6ffab0e into vitessio:master Apr 30, 2020
aquarapid added a commit to planetscale/vitess that referenced this pull request May 31, 2020
…gth offset into

account in writeBinaryRow().  Not an ideal fix, but something cleaner
will involve invasive cleanup.

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid added a commit that referenced this pull request Jun 1, 2020
account in writeBinaryRow().  Not an ideal fix, but something cleaner
will involve invasive cleanup.

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
sougou added a commit that referenced this pull request Jun 8, 2020
Fix issue #6240.  PR #6130 did not take the header length offset into
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants