Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Gather source positions once we know all writes are done during traffic switch #16572

Merged
merged 6 commits into from
Aug 19, 2024

Add test

fcdc8bd
Select commit
Loading
Failed to load commit list.
Merged

VReplication: Gather source positions once we know all writes are done during traffic switch #16572

Add test
fcdc8bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 16, 2024 in 0s

68.83% (-0.02%) compared to 127b9ae

View this Pull Request on Codecov

68.83% (-0.02%) compared to 127b9ae

Details

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.83%. Comparing base (127b9ae) to head (fcdc8bd).
Report is 1 commits behind head on main.

Files Patch % Lines
go/vt/vtctl/workflow/traffic_switcher.go 71.42% 4 Missing ⚠️
go/vt/vtctl/workflow/server.go 33.33% 2 Missing ⚠️
go/vt/vtctl/workflow/utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16572      +/-   ##
==========================================
- Coverage   68.84%   68.83%   -0.02%     
==========================================
  Files        1558     1558              
  Lines      200025   200048      +23     
==========================================
- Hits       137714   137694      -20     
- Misses      62311    62354      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.