-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL internal cleanup: using formal statements as opposed to textual SQL #16230
Merged
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:onlineddl-show-create-table-formal
Jun 20, 2024
Merged
Online DDL internal cleanup: using formal statements as opposed to textual SQL #16230
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:onlineddl-show-create-table-formal
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eatTable rather than textual statements Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16230 +/- ##
==========================================
+ Coverage 68.55% 68.61% +0.06%
==========================================
Files 1544 1544
Lines 197895 197948 +53
==========================================
+ Hits 135658 135829 +171
+ Misses 62237 62119 -118 ☔ View full report in Codecov by Sentry. |
mattlord
approved these changes
Jun 20, 2024
rohit-nayak-ps
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some internal refactoring, using more format
sqlparser.Statement
orsqlparser.CreateTable
etc. rather than raw SQL text.Related Issue(s)
Initial work for #16229
Checklist
Deployment Notes