Fix a number of encoding issues when evaluating expressions with the evalengine #13509
+1,589
−1,019
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| /* | ||
| Copyright 2023 The Vitess Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package hex | ||
dbussink marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| import ( | ||
| "encoding/hex" | ||
| "math/bits" | ||
| ) | ||
|
|
||
| const hextable = "0123456789ABCDEF" | ||
|
|
||
| func EncodeBytes(src []byte) []byte { | ||
|
There was a problem hiding this comment. These have been moved since we now used them in two places. |
||
| j := 0 | ||
| dst := make([]byte, len(src)*2) | ||
| for _, v := range src { | ||
| dst[j] = hextable[v>>4] | ||
| dst[j+1] = hextable[v&0x0f] | ||
| j += 2 | ||
| } | ||
| return dst | ||
| } | ||
|
|
||
| func EncodeUint(u uint64) []byte { | ||
| var a [16 + 1]byte | ||
| i := len(a) | ||
| shift := uint(bits.TrailingZeros(uint(16))) & 7 | ||
| b := uint64(16) | ||
| m := uint(16) - 1 // == 1<<shift - 1 | ||
|
|
||
| for u >= b { | ||
| i-- | ||
| a[i] = hextable[uint(u)&m] | ||
| u >>= shift | ||
| } | ||
|
|
||
| // u < base | ||
| i-- | ||
| a[i] = hextable[uint(u)] | ||
| return a[i:] | ||
| } | ||
|
|
||
| func DecodeUint(u uint64) []byte { | ||
| if u == 0 { | ||
| return []byte{0} | ||
| } | ||
| var decoded []byte | ||
| for u > 0 { | ||
| c1 := u % 10 | ||
| c2 := u % 100 / 10 | ||
| decoded = append([]byte{byte(c1 + c2<<4)}, decoded...) | ||
| u /= 100 | ||
| } | ||
| return decoded | ||
| } | ||
|
|
||
| func DecodedLen(src []byte) int { | ||
| return (len(src) + 1) / 2 | ||
| } | ||
|
|
||
| func DecodeBytes(dst, src []byte) bool { | ||
| if len(src)&1 == 1 { | ||
| src = append([]byte{'0'}, src...) | ||
| } | ||
| _, err := hex.Decode(dst, src) | ||
| return err == nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're now consistent with MySQL which upcases by default for hex literals.