Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] Miscellaneous code modifications based on observations made while doing a code walkthrough (#12873) #13280

Merged
merged 6 commits into from
Jun 13, 2023
Merged

[release-17.0] Miscellaneous code modifications based on observations made while doing a code walkthrough (#12873) #13280

merged 6 commits into from
Jun 13, 2023

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 9, 2023

Description

This is a backport of #12873.

@rohit-nayak-ps
Move to glog v1.1.0
dfaec6e 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>

Miscellaneous fixes based on an internal code audit

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

More mods

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

Add modified zkctl.txt

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

fix imports

Signed-off-by: Manan Gupta <manan@planetscale.com>
@rohit-nayak-ps
Address review comments
884af5f 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Remove statsd.go which came due to an incorrect merge
53ab1a3 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Address review comment
4688748 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Update flags help output
f7cf52a 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Switch back to glog v1.0.0 since moving to glog v1.1.0 trips up zooke…
d1c005b 
…eper docker tests in Shard 25

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@vitess-bot vitess-bot bot added the Backport This is a backport label Jun 9, 2023
@vitess-bot vitess-bot bot requested a review from GuptaManan100 as a code owner June 9, 2023 13:00
@vitess-bot vitess-bot bot added the Component: General Changes throughout the code base label Jun 9, 2023
@vitess-bot vitess-bot bot requested a review from shlomi-noach as a code owner June 9, 2023 13:00
@vitess-bot vitess-bot bot added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Jun 9, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 9, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jun 9, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone Jun 9, 2023
@deepthi deepthi removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 12, 2023
@frouioui frouioui modified the milestones: v17.0.0, v18.0.0 Jun 12, 2023
@frouioui frouioui modified the milestones: v18.0.0, v17.0.0 Jun 12, 2023
@frouioui frouioui merged commit ca3ee64 into release-17.0 Jun 13, 2023
@frouioui frouioui deleted the backport-12873-to-release-17.0 branch June 13, 2023 10:08
@jjpersch jjpersch mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188

Assignees
No one assigned
Labels
Backport This is a backport Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v17.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthi @rohit-nayak-ps @frouioui