Fix the returned schema object for broken views #12713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic added in vitessio#12675 has a small issue. When a view is found that has an error, it's not present anymore when a subsequent `.ToSQL()` call happens, so it looks like the view disappears. We should never have a view disappear since that could potentially break things and lead to unexpected results. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
shlomi-noach
approved these changes
Mar 23, 2023
dbussink
commented
Mar 23, 2023
| } | ||
| return schema, nil | ||
| err := schema.normalize() | ||
| return schema, err |
There was a problem hiding this comment.
Small equivalent simplification here.
| @@ -309,16 +307,18 @@ func (s *Schema) normalize() error { | |||
| // - two or more views have a circular dependency | |||
| for _, t := range s.tables { | |||
| if _, ok := dependencyLevels[t.Name()]; !ok { | |||
| // We _know_ that in this iteration, at least one view is found unassigned a dependency level. | |||
| // We _know_ that in this iteration, at least one foreign key is not found. | |||
There was a problem hiding this comment.
comment was wrong here as well.
| errs = errors.Join(errs, &ViewDependencyUnresolvedError{View: v.ViewName.Name.String()}) | ||
| // We still add it so it shows up in the output if that is used for anything. | ||
| s.sorted = append(s.sorted, v) |
There was a problem hiding this comment.
Fixed the logic and the comment.
frouioui
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic added in #12675 has a small issue. When a view is found that has an error, it's not present anymore when a subsequent
.ToSQL()call happens, so it looks like the view disappears.We should never have a view disappear since that could potentially break things and lead to unexpected results.
Related Issue(s)
Issue introduced in #12675
Checklist