Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: go/vt/vtgate/engine/opcode to reduce semantics package dependencies #12663

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Refactor: go/vt/vtgate/engine/opcode to reduce semantics package dependencies #12663

merged 3 commits into from
Mar 20, 2023

Conversation

shlomi-noach
Copy link
Contributor

Description

This is an internal refactor PR, that creates a new package: go/vt/vtgate/engine/opcode. With this new package, we can remove go/vt/vtgate/semantics's dependency on go/vt/vtgate/engine. Now both semantics and engine use the new opcode package.

This decoupling was found necessary in #12565 (comment), and helps to untangle #12565

Related Issue(s)

#12565

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
Refactor: go/vt/vtgate/engine/opcode to reduce semantics package depe…
017e10d 
…ndencies

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
add new package
eac2860 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
copyright
4daa08b 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
dbussink
dbussink approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion.

go/vt/vtgate/semantics/scoper.go Show resolved Hide resolved
@shlomi-noach shlomi-noach mentioned this pull request Mar 20, 2023
Merged
3 tasks
@shlomi-noach shlomi-noach changed the title Refactor: go/vt/vtgate/engine/opcode to reduce semantics package dependencies Refactor: go/vt/vtgate/engine/opcode to reduce semantics package dependencies Mar 20, 2023
@shlomi-noach shlomi-noach merged commit d9f420f into vitessio:main Mar 20, 2023
@shlomi-noach shlomi-noach deleted the resolve-semantics-engine-deps branch March 20, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui left review comments

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rsajwani rsajwani Awaiting requested review from rsajwani

@systay systay Awaiting requested review from systay systay is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shlomi-noach @dbussink @harshit-gangal @frouioui