Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to go1.20.1 #12399

Merged
merged 9 commits into from
Feb 28, 2023
Merged

Upgrade to go1.20.1 #12399

merged 9 commits into from
Feb 28, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Feb 21, 2023 •
edited
Loading

Description

This PR upgrades the golang version used in vitess main from go1.19.4 to go1.20.1. By doing this, we are fixing several vulnerabilities that are affecting our codebase.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@frouioui
Upgrade to go1.20.1
4fcf9d2 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: General Changes throughout the code base go Skip CI Skip CI actions from running labels Feb 21, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 21, 2023 •
edited by frouioui
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 21, 2023
@frouioui frouioui added Do Not Merge and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says Skip CI Skip CI actions from running labels Feb 21, 2023
@frouioui
Bump golangci-lint version
908d1a9 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the upgrade-to-go1.20.1-on-main branch from c35f201 to 908d1a9 Compare February 21, 2023 13:12
@frouioui @deepthi
Apply linter suggestions
2d42fcd 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: deepthi <deepthi@planetscale.com>
@frouioui @deepthi
fix TestTLSClientVerifyIdentity
9b90f61 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@deepthi
Copy link
Member

deepthi commented Feb 28, 2023

Related: #12398
I picked a couple of commits from that PR to try and get CI passing on this.

@deepthi
Merge branch 'main' into upgrade-to-go1.20.1-on-main
cedcaa3 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
Copy link
Member

deepthi commented Feb 28, 2023

Don't understand why Unit Test (mysql57) is failing with exit code 143. Merged in main to skip launchable so that we get all the output in CI.

@frouioui frouioui added the Skip CI Skip CI actions from running label Feb 28, 2023
@frouioui
Revert unwanted change in server_test
425362d 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Copy link
Member Author

Don't understand why Unit Test (mysql57) is failing with exit code 143. Merged in main to skip launchable so that we get all the output in CI.

Recently saw the same issue. cedcaa3 had all unit test workflows green.

@frouioui frouioui linked an issue Feb 28, 2023 that may be closed by this pull request
Unhandled error in VTOrc recoverDeadPrimary #12509
Closed
@frouioui frouioui removed the Skip CI Skip CI actions from running label Feb 28, 2023
@frouioui
handle readtablet error
4e00f98 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the upgrade-to-go1.20.1-on-main branch from 42eb6db to 4e00f98 Compare February 28, 2023 13:03
@frouioui frouioui requested a review from deepthi February 28, 2023 13:03
@frouioui frouioui marked this pull request as ready for review February 28, 2023 13:03
@frouioui
skip TestFuzz
1438b45 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Feb 28, 2023
Closed
@frouioui
Unskip TestFuzz and fix issue
92d842f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui linked an issue Feb 28, 2023 that may be closed by this pull request
Bug Report: TestFuzz hangs on go1.20.1 #12513
Closed
deepthi
deepthi reviewed Feb 28, 2023
View reviewed changes
go/bucketpool/bucketpool_test.go
maxTestSize := 16384
for i := 0; i < 20000; i++ {
minSize := rand.Intn(maxTestSize)
if minSize == 0 {
minSize = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would have just skipped this iteration (continue) when minSize == 0.

deepthi
deepthi approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@frouioui frouioui merged commit 3ff3c47 into vitessio:main Feb 28, 2023
@frouioui frouioui deleted the upgrade-to-go1.20.1-on-main branch February 28, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 left review comments

@dbussink dbussink dbussink approved these changes

@deepthi deepthi deepthi approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@rsajwani rsajwani Awaiting requested review from rsajwani

@systay systay Awaiting requested review from systay systay is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@ajm188 ajm188 Awaiting requested review from ajm188

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: TestFuzz hangs on go1.20.1 Unhandled error in VTOrc recoverDeadPrimary
5 participants
@frouioui @deepthi @dbussink @shlomi-noach @GuptaManan100