Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to disable lookup read lock #11538

Merged
merged 1 commit into from
Nov 2, 2022
Merged

add option to disable lookup read lock #11538

merged 1 commit into from
Nov 2, 2022

Conversation

maxenglander
Copy link
Collaborator

@maxenglander maxenglander commented Oct 19, 2022 •
edited
Loading

Description

(This PR is based on this other PR. Once that PR is merged, will refresh this one and take out of draft state. See here for accurate diff.)

DML to lookup VIndexes unconditionally takes a row lock on rows in the lookup VIndex backing table. Add an option to optionally elide this lock for cases where we know via business logic that the row will not be deleted, nor the lookup column changed.

Related Issue(s)

Fixes #11612

Checklist

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 19, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@maxenglander maxenglander added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Oct 19, 2022
@harshit-gangal
Copy link
Member

This would need website documentation.

@maxenglander
Copy link
Collaborator Author

Thanks @harshit-gangal will follow-up here once the PRs for no_verify get merged.

@maxenglander maxenglander force-pushed the maxeng-opt-disable-locking-read branch from a930e87 to c319e57 Compare October 24, 2022 18:00
@maxenglander maxenglander mentioned this pull request Oct 24, 2022
Merged
@maxenglander maxenglander marked this pull request as ready for review October 24, 2022 18:17
@maxenglander
Copy link
Collaborator Author

@harshit-gangal PR for docs: vitessio/website#1193

@maxenglander maxenglander marked this pull request as draft October 24, 2022 18:28
@maxenglander
add option to disable lookup read lock
dde60d6 
DML to lookup VIndexes unconditionally takes a row lock on rows in the
lookup VIndex backing table. Add an option to optionally elide this lock
for cases where we know via business logic that the row will not be
deleted, nor the lookup column changed.

Signed-off-by: Max Englander <max@planetscale.com>
@maxenglander maxenglander force-pushed the maxeng-opt-disable-locking-read branch from c319e57 to dde60d6 Compare October 24, 2022 19:03
@maxenglander maxenglander marked this pull request as ready for review October 24, 2022 19:54
@deepthi
Copy link
Member

deepthi commented Oct 31, 2022

@maxenglander while we wait for re-review from harshit, do you mind creating a Feature Request issue for this and linking it in?
Something like Option to optimize locking for lookup Vindexes... or whatever you think is best.

@maxenglander
Copy link
Collaborator Author

@deepthi will do, thank you!

harshit-gangal
harshit-gangal approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshit-gangal harshit-gangal removed the NeedsWebsiteDocsUpdate What it says label Nov 2, 2022
@harshit-gangal harshit-gangal merged commit 1c710f3 into vitessio:main Nov 2, 2022
@maxenglander maxenglander deleted the maxeng-opt-disable-locking-read branch January 11, 2023 16:06
arthurschreiber pushed a commit to github/vitess-gh that referenced this pull request May 16, 2023
@maxenglander @arthurschreiber
add option to disable lookup read lock (vitessio#11538)
51f1025 
DML to lookup VIndexes unconditionally takes a row lock on rows in the
lookup VIndex backing table. Add an option to optionally elide this lock
for cases where we know via business logic that the row will not be
deleted, nor the lookup column changed.

Signed-off-by: Max Englander <max@planetscale.com>

Signed-off-by: Max Englander <max@planetscale.com>
@arthurschreiber arthurschreiber mentioned this pull request May 16, 2023
Merged
arthurschreiber pushed a commit to github/vitess-gh that referenced this pull request Oct 10, 2023
@maxenglander @arthurschreiber
add option to disable lookup read lock (vitessio#11538)
8603fda 
DML to lookup VIndexes unconditionally takes a row lock on rows in the
lookup VIndex backing table. Add an option to optionally elide this lock
for cases where we know via business logic that the row will not be
deleted, nor the lookup column changed.

Signed-off-by: Max Englander <max@planetscale.com>

Signed-off-by: Max Englander <max@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: option to optimize locking for lookup Vindexes
3 participants
@maxenglander @harshit-gangal @deepthi