-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle aliasing of collation names #11433
Merged
GuptaManan100
merged 1 commit into
vitessio:main
from
planetscale:dbussink/handle-collation-aliasing
Oct 5, 2022
Merged
Handle aliasing of collation names #11433
GuptaManan100
merged 1 commit into
vitessio:main
from
planetscale:dbussink/handle-collation-aliasing
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
labels
Oct 4, 2022
dbussink
requested review from
harshit-gangal,
systay and
mattlord
as code owners
October 4, 2022 12:13
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
With MySQL 8.0.30 and later, utf8mb3 is always reported as the charset in output for `SHOW CREATE TABLE` which is what `schemadiff` uses. We already today normalize all `charset` output to use the `utf8mb3` name to avoid any ambiguity in what is intended. We didn't do this though for collations. Today if `schemadiff` is fed schemas generated both with MySQL 8.0.30 and older versions to compare, it would indicate there's a difference when there is none. The change here always normalizes to use the more explicit `utf8mb3_` names for the collation if it can be found, based on the charset aliases configured. This ensures that comparisons between such schemas don't see accidental or stray diffs that are not really changes. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
force-pushed
the
dbussink/handle-collation-aliasing
branch
from
October 4, 2022 12:26
5d04bce
to
970e381
Compare
GuptaManan100
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
dbussink
added a commit
that referenced
this pull request
Oct 5, 2022
With MySQL 8.0.30 and later, utf8mb3 is always reported as the charset in output for `SHOW CREATE TABLE` which is what `schemadiff` uses. We already today normalize all `charset` output to use the `utf8mb3` name to avoid any ambiguity in what is intended. We didn't do this though for collations. Today if `schemadiff` is fed schemas generated both with MySQL 8.0.30 and older versions to compare, it would indicate there's a difference when there is none. The change here always normalizes to use the more explicit `utf8mb3_` names for the collation if it can be found, based on the charset aliases configured. This ensures that comparisons between such schemas don't see accidental or stray diffs that are not really changes. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With MySQL 8.0.30 and later, utf8mb3 is always reported as the charset in output for
SHOW CREATE TABLE
which is whatschemadiff
uses. We already today normalize allcharset
output to use theutf8mb3
name to avoid any ambiguity in what is intended.We didn't do this though for collations. Today if
schemadiff
is fed schemas generated both with MySQL 8.0.30 and older versions to compare, it would indicate there's a difference when there is none.The change here always normalizes to use the more explicit
utf8mb3_
names for the collation if it can be found, based on the charset aliases configured. This ensures that comparisons between such schemas don't see accidental or stray diffs that are not really changes.Related Issue(s)
This is part of the #10203 schemadiff work.
Checklist