-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTOrc cleanup: Remove unused CLI code and move relevant APIs to the new VTOrc UI #11370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…scope Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…tests for the api/problems API Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
2e32305
to
821426c
Compare
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
deepthi
approved these changes
Sep 28, 2022
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: VTorc
Vitess Orchestrator integration
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the unused CLI code from VTOrc and also removes the APIs register on the VTOrc's old UI that it inherited from the orchestrator.
Instead, a bunch of APIs have been moved to the
servenv
architecture that is now available with VTOrc. We can even port more APIs from the old UI as we see fit.This PR moved the following APIs -
/api/problems
- moved with the same name and prints the instances that have problems. Also, the API has been extended to support filtering using the keyspace and shard name./api/disable-global-recoveries
- moved while remaining functionally the same/api/enable-global-recoveries
- moved while remaining functionally the same/api/health
- Moved to/debug/health
in accordance with the other binaries in Vitess/api/replication-analysis
- Moved while remaining functionally the same. The output format is slightly different now. It is json format and parseable on the user end./api/lb-check
or/api/_ping
- These have not been moved, since we already getdebug/liveness
out of the box withservenv
.Related Issue(s)
Checklist
Deployment Notes