Getting rid of external logging

[rsajwani]

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

Description

This PR will remove dependency from orchestrator/external/golib/log and use vitess/go/vt/log in VTORC.

Log entries before the change

I0824 10:42:08.275460 26474 log.go:226] starting orchestrator
2022-08-24 10:42:08 DEBUG db.go:148] Connected to orchestrator backend: sqlite on file::memory:?mode=memory&cache=shared
2022-08-24 10:42:08 DEBUG db.go:181] Initializing orchestrator
2022-08-24 10:42:08 DEBUG db.go:316] Migrating database schema
2022-08-24 10:42:08 DEBUG db.go:242] Migrated database schema to version []
2022-08-24 10:42:08 INFO db.go:196] Connecting to backend :3306: maxConnections: 128, maxIdleConns: 32
I0824 10:42:08.340530 26474 log.go:226] Starting Discovery
I0824 10:42:08.340548 26474 log.go:226] Registering endpoints
2022-08-24 10:42:08 INFO orchestrator.go:343] continuous discovery: setting up
2022-08-24 10:42:08 DEBUG queue.go:96] Queue.startMonitoring(DEFAULT)
2022-08-24 10:42:08 INFO http.go:165] Starting HTTP listener on :6931
2022-08-24 10:42:08 INFO orchestrator.go:375] continuous discovery: starting

Log entries after the change

I0824 10:55:34.771867 32574 main.go:183] starting orchestrator
I0824 10:55:34.773021 32574 config.go:512] Read config: /Users/rameezsajwani/Code/fork/vitess/vtdataroot/vtroot_7101/tmp_7103/orc-config-1661363733717036000.json
I0824 10:55:34.773237 32574 db.go:148] Connected to orchestrator backend: sqlite on file::memory:?mode=memory&cache=shared
I0824 10:55:34.773256 32574 db.go:311] Initializing orchestrator
I0824 10:55:34.774282 32574 db.go:321] Migrating database schema
I0824 10:55:34.830636 32574 db.go:244] Migrated database schema to version []
I0824 10:55:34.830699 32574 db.go:198] Connecting to backend :3306: maxConnections: 128, maxIdleConns: 32
I0824 10:55:34.835418 32574 http.go:130] Starting Discovery
I0824 10:55:34.835438 32574 http.go:134] Registering endpoints
I0824 10:55:34.835499 32574 orchestrator.go:344] continuous discovery: setting up
I0824 10:55:34.835940 32574 queue.go:96] Queue.startMonitoring(DEFAULT)
I0824 10:55:34.840009 32574 http.go:165] Starting HTTP listener on :7131
I0824 10:55:34.843928 32574 orchestrator.go:376] continuous discovery: starting

Related Issue(s)

Checklist

• "Backport me!" label has been added if this change should be backported
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
• If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

• There should be at least one unit or end-to-end test.
• The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

• There should be some code comments as to why things are implemented the way they are.

New/Existing features

• Should be documented, either by modifying the existing documentation or creating new documentation.
• New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• vtctl command output order should be stable and awk-able.

[GuptaManan100]

Looks good to me! This is awesome!