Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of PARTITION BY KEY #10958

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Fix parsing of PARTITION BY KEY #10958

merged 2 commits into from
Aug 8, 2022

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Aug 8, 2022 •
edited
Loading

The PARTITION BY KEY syntax allows for passing in an empty column list which signifies that the primary key is used for partitioning.

This needs to be added to the parser to support this case.

See also https://dev.mysql.com/doc/refman/8.0/en/partitioning-key.html, specifically:

KEY takes only a list of zero or more column names. Any columns used as the partitioning key must
comprise part or all of the table's primary key, if the table has one. Where no column name is
specified as the partitioning key, the table's primary key is used, if there is one.

Related Issue(s)

Found as part of #10203

Fixes #10959

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@dbussink
Fix parsing of PARTITION BY KEY
3f06523 
The `PARTITION BY KEY` syntax allows for passing in an empty column list
which signifies that the primary key is used for partitioning.

This needs to be added to the parser to support this case.

See also https://dev.mysql.com/doc/refman/8.0/en/partitioning-key.html

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 8, 2022 •
edited by GuptaManan100
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@dbussink dbussink marked this pull request as ready for review August 8, 2022 12:18
GuptaManan100
GuptaManan100 reviewed Aug 8, 2022
View reviewed changes
go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
@dbussink
Simplify parser
5a4f8a6 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@GuptaManan100
Copy link
Member

@dbussink Do you mind creating an issue for the bug as well?

@dbussink dbussink mentioned this pull request Aug 8, 2022
Closed
@GuptaManan100 GuptaManan100 merged commit efa842e into vitessio:main Aug 8, 2022
@GuptaManan100 GuptaManan100 deleted the dbussink/fix-partition-by-key-parsing branch August 8, 2022 15:43
@shlomi-noach
Copy link
Contributor

A new day, a new MySQL parser syntax surprise.

systay pushed a commit to planetscale/vitess that referenced this pull request Aug 19, 2022
@dbussink
Fix parsing of PARTITION BY KEY (vitessio#10958) (vitessio#932)
b0a2d11 
* Fix parsing of `PARTITION BY KEY`

The `PARTITION BY KEY` syntax allows for passing in an empty column list
which signifies that the primary key is used for partitioning.

This needs to be added to the parser to support this case.

See also https://dev.mysql.com/doc/refman/8.0/en/partitioning-key.html

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* Simplify parser

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: PARTITION BY KEY() is not parsed correctly.
3 participants
@dbussink @GuptaManan100 @shlomi-noach