schemadiff: rich error for unmet view dependencies #10940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
dbussink
reviewed
Aug 4, 2022
| @@ -239,3 +238,11 @@ func (e *InvalidColumnInForeignKeyConstraintError) Error() string { | |||
| return fmt.Sprintf("invalid column %s referenced by foreign key constraint %s in table %s", | |||
| sqlescape.EscapeID(e.Column), sqlescape.EscapeID(e.Constraint), sqlescape.EscapeID(e.Table)) | |||
| } | |||
|
|
|||
| type ViewDependencyUnresolvedError struct { | |||
| View string | |||
There was a problem hiding this comment.
Can we also here have a reference to the entity it tries to refer to? Like if a another table / view is missing, we'd also know the name here as well?
We could then further improve the error to "view %s references unknown entity %s" or something along those lines?
And maybe different from having a loop and have a separate error type for that?
There was a problem hiding this comment.
So the way we detect these dependencies is by creating a connected graph, and then looking at "what's outside the graph". We don't explicitly then check which tables/views are referenced by the left-out views. We could definitely do that.
There was a problem hiding this comment.
@dbussink let's iterate on that in a followup PR though, if that's OK
There was a problem hiding this comment.
Yeah, we can improve on a further iteration.
iheanyi
approved these changes
Aug 4, 2022
go/vt/schemadiff/schema.go
Outdated
| return ErrViewDependencyUnresolved | ||
| for _, v := range s.views { | ||
| if _, ok := dependencyLevels[v.Name()]; !ok { | ||
| // We _know_ that in this iteration, at least one view is found unassugned a dependency level. |
There was a problem hiding this comment.
Suggested change
| // We _know_ that in this iteration, at least one view is found unassugned a dependency level. | |
| // We _know_ that in this iteration, at least one view is found unassigned a dependency level. |
dbussink
approved these changes
Aug 6, 2022
| @@ -239,3 +238,11 @@ func (e *InvalidColumnInForeignKeyConstraintError) Error() string { | |||
| return fmt.Sprintf("invalid column %s referenced by foreign key constraint %s in table %s", | |||
| sqlescape.EscapeID(e.Column), sqlescape.EscapeID(e.Constraint), sqlescape.EscapeID(e.Table)) | |||
| } | |||
|
|
|||
| type ViewDependencyUnresolvedError struct { | |||
| View string | |||
There was a problem hiding this comment.
Yeah, we can improve on a further iteration.
3 tasks
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 19, 2022
…itessio#959) * schemadiff: rich error for unmet view dependencies Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * grammar Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * typo Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR turns the flat
ErrViewDependencyUnresolvederror into a richerViewDependencyUnresolvedError, indicating the identity of the view in question.Existing tests adapted to new error type.
Related Issue(s)
Checklist
Deployment Notes