Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemadiff: analyze and apply ADD PARTITION and DROP PARTITION statements #10234

Merged

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented May 8, 2022

Description

In this PR, schemadiff is able to:

  • Generate multiple diffs for a table diff. A new function, EntityDiff.SubsequentDiff() returns the next-in-line diff for a given diff (or nil) if these is none. Essentially, a diff is the head of a linked list. The helper function AllSubsequent() turns such a linked list into a slice.

    • the single use case for this new behavior right now (and for as long as I can predict) is partitioing, illustrated below.
  • Utilize RangeRotationStatements in DiffHints

  • Diff two range-partition tables and analyze a sequence of DROP PARTITION and ADD PARTITION diffs. If partitions have rotated between the two tables (dropped "old" partitions from the 1st, added "new" partitions to the 2nd) then Diff() returns a sequence of EntityDiffs, approachable via SubsequentDiff() (see above), that can only be applied in-order to get into the new table format. These begin with the oldest DROP PARTITION and end up with the newest ADD PARTITION.

  • Apply() now not only applies the given EntityDiff but also implicitly all subsequent diffs.

    • As a reminder, when RangeRotationStrategy is RangeRotationFullSpec (the default) we just get a single AlterTableEntityDiff which has the full partitioning spec
    • Also as reminder, when RangeRotationStrategy is RangeRotationIgnore , and if this is a range partition rotation, the partitioning change is silently ignored. If this is not a rotation, a full spec is generated.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes none labels May 8, 2022
@shlomi-noach shlomi-noach requested a review from dbussink May 8, 2022 14:36
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach marked this pull request as draft May 9, 2022 08:47
@shlomi-noach
Copy link
Contributor Author

I've converted this PR to Draft. I want to explore an idea by @dbussink where a table diff might generate a sequence of diffs, not just a single one; such that we might diff two tables with multiple partition rotation changes, and generate a one-change-at-a-time sequence of alters.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…ons/diffs. Implemented in range partitioning diffs

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…hemadiff-add-drop-partition-statements

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach marked this pull request as ready for review May 10, 2022 12:27
@shlomi-noach
Copy link
Contributor Author

Ready to review: this PR now supports a diff that is a sequence of steps, in particular a sequence of DROP PARTITION and ADD PARTITION that compose a complex range partition rotation operation.

Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question here, but nothing blocking.

go/vt/schemadiff/table.go Outdated Show resolved Hide resolved
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach merged commit 7a792e7 into vitessio:main May 10, 2022
@shlomi-noach shlomi-noach deleted the schemadiff-add-drop-partition-statements branch May 10, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants