schemadiff: CanonicalStatementString(), utilize sqlparser.CanonicalString() #10142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring() Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
Getting a legit failure from Looking into it. Tests are the best. |
|
depends on fixing #10143 |
|
converted to draft while tests are failing. |
vmg
approved these changes
Apr 27, 2022
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
merged |
|
Going to merge this PR with |
|
Tracking issue: #10203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#10068 introduced
sqlparser.CanonicalString()which prints out statements in a canonical aka "standard" format: capitals for SQL keywords, fully qualified names etc.In this PR
schemadiffsupports the new format by exposing aCanonicalStatementString()for all diff entities.Declarative migrations now use the canonical query over the default query format.
All unit tests now validate both default query format and canonical query format.
endtoendtests switched to using the canonical format.Related Issue(s)
#10068
Checklist