vttablet refactor: address review comments

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
vitessio · Jul 23, 2020 · dce6346 · dce6346
1 parent 1555def
commit dce6346
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/config/tablet/default.yaml b/config/tablet/default.yaml
@@ -99,7 +99,6 @@ hotRowProtection:
   maxConcurrency: 5           # hot_row_protection_concurrent_transactions
 
 consolidator: enable|disable|notOnMaster # enable-consolidator, enable-consolidator-replicas
-transitionGracePeriodSeconds: 0          # serving_state_grace_period
 passthroughDML: false                    # queryserver-config-passthrough-dmls
 streamBufferSize: 32768                  # queryserver-config-stream-buffer-size
 queryCacheSize: 5000                     # queryserver-config-query-cache-size

diff --git a/go/test/endtoend/cluster/mysqlctl_process.go b/go/test/endtoend/cluster/mysqlctl_process.go
@@ -93,7 +93,7 @@ func (mysqlctl *MysqlctlProcess) StartProcess() (*exec.Cmd, error) {
 // Stop executes mysqlctl command to stop mysql instance
 func (mysqlctl *MysqlctlProcess) Stop() (err error) {
 	log.Infof("Shutting down MySQL: %d", mysqlctl.TabletUID)
-	defer log.Infof("MySQL shurdown complete: %d", mysqlctl.TabletUID)
+	defer log.Infof("MySQL shutdown complete: %d", mysqlctl.TabletUID)
 	tmpProcess, err := mysqlctl.StopProcess()
 	if err != nil {
 		return err

diff --git a/go/test/endtoend/tabletmanager/tablet_health_test.go b/go/test/endtoend/tabletmanager/tablet_health_test.go
@@ -126,7 +126,7 @@ func TestHealthCheck(t *testing.T) {
 
 	// stop replication, make sure we don't go unhealthy.
 	// TODO: replace with StopReplication once StopSlave has been removed
-	err = clusterInstance.VtctlclientProcess.ExecuteCommand("StopReplication", rTablet.Alias)
+	err = clusterInstance.VtctlclientProcess.ExecuteCommand("StopSlave", rTablet.Alias)
 	require.NoError(t, err)
 	err = clusterInstance.VtctlclientProcess.ExecuteCommand("RunHealthCheck", rTablet.Alias)
 	require.NoError(t, err)