Improve vtop release process by creating the Release PR first #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi
approved these changes
Nov 9, 2024
rohit-nayak-ps
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is long due, it finally changes the release process of vitess-operator by making sure the Release PR is created first. It breaks down the current
Create vitess-operator release PRstep into multiple steps:Create vitess-operator Release PRMerge the vitess-operator Release PR(new step)Tag the vitess-operator release(new step)Back To Dev Mode vitess-operator(new step)Manual update of vitess-operator testsThe first step shown above is now only responsible for creating the Release PR (instead of doing everything that's automated), and the last step was moved from the early stage of the
Releasephase to the very end of the phase.As we must create the vtop Release PR once the Vitess release is out (they're linked to each other, vtop uses the new vitess tags as a dependency), we run the
merge vtop release PRstep and all the following steps at the very end of the phase so, hopefully, CI has time to run and the release team does not encounter a big bottleneck.I did an entire 'fake' release on my own fork and everything looked good to me, the issue contains all the links to the PRs that were created during that test: frouioui/vitess#368.