Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete unused try catch #4638

Merged
merged 1 commit into from
Aug 17, 2021
Merged

refactor: delete unused try catch #4638

merged 1 commit into from
Aug 17, 2021

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented Aug 17, 2021

Description

The reason for try catch is in #1977.
It looks like never throw an error now. I try to use /%public% request vite server and also won't be failed. I guess the decoding problem is fixed in #4600.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Aug 17, 2021
@patak-dev patak-dev changed the title refactor(vite): delete unused try catch refactor: delete unused try catch Aug 17, 2021
@patak-dev patak-dev merged commit ad71494 into vitejs:main Aug 17, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants