Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shared): simplify isPrimitive() #19192

Closed
wants to merge 1 commit into from

Conversation

parkin-lin
Copy link

simplify isPrimitive()

@patak-dev
Copy link
Member

Could you provide more context about why we should adopt this simplification? Won't this be creating new Objects to garbage collect after the change?

@parkin-lin
Copy link
Author

Sorry, I'm not thinking specifically about memory or speed optimisations here, as this isPrimitive() method isn't being called multiple times in the critical path.
It's just a logical simplification in code style, so if it's not more readable, maybe we can close this PR. Thanks for your feedback.

@patak-dev
Copy link
Member

thanks for the PR, but yes, let's close it for now and apply these kind of changes when there is a clear optimization or fix.

@patak-dev patak-dev closed this Jan 13, 2025
@parkin-lin parkin-lin deleted the refactor/isPrimitive branch January 13, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants