fix(css): workaround tsx esModule interop of sass-embedded import #19182
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sass
dynamic import is undefined when building with "modern-compiler" and sass-embedded #19052__esModule
interop is applied to .cjs files privatenumber/tsx#627As seen in privatenumber/tsx#627, tsx unwraps named exports for
__esModule
and thus strips offdefault
export. The issue seems to be acknowledged as node inconsistency bug, but I'm not sure about the plan. Vite side fallback is simple, so probably it's worth having it.From my quick read through, tsx transforms
import(xxx)
to unwrapdefault
for__esModule
automatically (transform-dynamic-import.ts). This seems to happen for all esm code loaded via tsx (load.ts).I tested four combinations locally based on https://github.com/hi-ogawa/reproductions/tree/main/vite-19182-sass-tsx