feat: support async for proxy.bypass

packages/vite/src/node/server/middlewares/proxy.ts

@@ -187,7 +187,7 @@ export function proxyMiddleware(
                   socket.end('HTTP/1.1 404 Not Found\r\n\r\n', '')
                   return
                 }
-              } catch (e) {
+              } catch (err) {
                 config.logger.error(
                   `${colors.red(`ws proxy bypass error:`)}\n${err.stack}`,
                   {

playground/proxy-bypass/__tests__/proxy-bypass.spec.ts

@@ -1,8 +1,19 @@
 import { expect, test, vi } from 'vitest'
-import { browserLogs } from '~utils'
+import { browserLogs, isServe, page, serverLogs } from '~utils'
 
 test('proxy-bypass', async () => {
   await vi.waitFor(() => {
     expect(browserLogs.join('\n')).toContain('status of 404 (Not Found)')
   })
 })
+
+test('async-proxy-bypass', async () => {
+  const content = await page.frame('async-response').content()
+  expect(content).toContain('Hello after 4 ms (async timeout)')
+})
+
+test.runIf(isServe)('async-proxy-bypass-with-error', async () => {
+  await vi.waitFor(() => {
+    expect(serverLogs.join('\n')).toContain('bypass error')
+  })
+})

playground/proxy-bypass/index.html

@@ -1,2 +1,4 @@
 root app<br />
 <iframe src="/nonExistentApp" style="border: 0"></iframe>
+<iframe src="/asyncResponse" name="async-response"></iframe>
+<iframe src="/asyncThrowingError"></iframe>

playground/proxy-bypass/vite.config.js

@@ -1,5 +1,7 @@
 import { defineConfig } from 'vite'
 
+const timeout = (ms) => new Promise((r) => setTimeout(r, ms))
+
 export default defineConfig({
   server: {
     port: 9606,
@@ -10,6 +12,22 @@ export default defineConfig({
           return false
         },
       },
+      '/asyncResponse': {
+        bypass: async (_, res) => {
+          await timeout(4)
+          res.writeHead(200, {
+            'Content-Type': 'text/plain',
+          })
+          res.end('Hello after 4 ms (async timeout)')
+          return '/asyncResponse'
+        },
+      },
+      '/asyncThrowingError': {
+        bypass: async () => {
+          await timeout(4)
+          throw new Error('bypass error')
+        },
+      },
     },
   },
 })