Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose createServerModuleRunnerTransport #18730

Merged
merged 4 commits into from
Jan 23, 2025
Merged

feat: expose createServerModuleRunnerTransport #18730

merged 4 commits into from
Jan 23, 2025

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Nov 21, 2024 •
edited
Loading

Description

Since we can't just provide a fetchModule function anymore, let's expose the helper.

@sapphi-red
Copy link
Member

I think we need to expose NormalizedServerHotChannel type. Otherwise, users would have to use as any.

vite/packages/vite/src/node/ssr/runtime/serverModuleRunner.ts

Line 131 in c45576a

channel: environment.hot as NormalizedServerHotChannel,

@sheremet-va sheremet-va force-pushed the feat/expose-server-mr-transport branch from fc6eb9d to 8d2d100 Compare December 9, 2024 15:35
@sapphi-red sapphi-red added p2-nice-to-have Not breaking anything but nice to have (priority) feat: environment API Vite Environment API labels Dec 10, 2024
@sapphi-red sapphi-red added this to the 6.1 milestone Dec 10, 2024
@patak-dev patak-dev merged commit 8c24ee4 into vitejs:main Jan 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
feat: environment API Vite Environment API p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sheremet-va @sapphi-red @patak-dev