chore: tweak build config #18622
Merged
chore: tweak build config #18622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Nov 8, 2024
| @@ -94,6 +94,7 @@ function createSharedNodePlugins({ | |||
| // Since ws is not that perf critical for us, just ignore these deps. | |||
| ignore: ['bufferutil', 'utf-8-validate'], | |||
| sourceMap: false, | |||
| strictRequires: 'auto', | |||
There was a problem hiding this comment.
To get slightly smaller bundle.
| format: 'cjs', | ||
| externalLiveBindings: false, | ||
| freeze: false, | ||
| sourcemap: false, |
There was a problem hiding this comment.
sourcemap is not set in sharedNodeOptions.output, but removed because the default value is false.
Comment on lines
+301
to
+302
| if (!code.includes('__require')) return | ||
|
|
There was a problem hiding this comment.
Only inject __require if needed.
Comment on lines
-21
to
-22
| // lightningcss types are bundled | ||
| ...Object.keys(pkg.devDependencies).filter((d) => d !== 'lightningcss'), |
There was a problem hiding this comment.
This has changed by #18460
patak-dev
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description