Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime): seal ES module namespace object instead of feezing #15914

Merged
merged 1 commit into from
Feb 14, 2024
Merged

refactor(runtime): seal ES module namespace object instead of feezing #15914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,22 @@ describe('vite-runtime initialization', async () => {

it('exports is not modifiable', async ({ runtime }) => {
const mod = await runtime.executeUrl('/fixtures/simple.js')
expect(Object.isSealed(mod)).toBe(true)
expect(() => {
mod.test = 'I am modified'
}).toThrowErrorMatchingInlineSnapshot(
`[TypeError: Cannot set property test of [object Module] which has only a getter]`,
)
expect(() => {
delete mod.test
}).toThrowErrorMatchingInlineSnapshot(
`[TypeError: Cannot delete property 'test' of [object Module]]`,
)
expect(() => {
Object.defineProperty(mod, 'test', { value: 'I am modified' })
}).toThrowErrorMatchingInlineSnapshot(
`[TypeError: Cannot redefine property: test]`,
)
expect(() => {
mod.other = 'I am added'
}).toThrowErrorMatchingInlineSnapshot(
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/node/ssr/runtime/esmRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class ESModulesRunner implements ViteModuleRunner {
context[ssrExportAllKey],
)

Object.freeze(context[ssrModuleExportsKey])
Object.seal(context[ssrModuleExportsKey])
}

runExternalModule(filepath: string): Promise<any> {
Expand Down