Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): silence warn dynamic import module when inlineDynamicImports true #13970

Merged
merged 3 commits into from
Aug 1, 2023
Merged

fix(build): silence warn dynamic import module when inlineDynamicImports true #13970

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9dac35b
feat(build): silence warn dynamic import module when inlineDynamicImp…
Disservin Jul 27, 2023
f92b16f
use NormalizedOutputOptions
Disservin Jul 27, 2023
cffb61b
Merge branch 'main' into 13967-silence-warning
Disservin Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use NormalizedOutputOptions
  • Loading branch information
@Disservin
Disservin committed Jul 27, 2023
commit f92b16f696d95eeaa61ecc78ef359c2fc7342141
11 changes: 2 additions & 9 deletions packages/vite/src/node/plugins/reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,8 @@ export function buildReporterPlugin(config: ResolvedConfig): Plugin {
compressedCount = 0
},

renderChunk(code, chunk) {
const rollupOptionsOutput = config.build.rollupOptions.output
const inlineDynamic = (
Array.isArray(rollupOptionsOutput)
? rollupOptionsOutput[0]
: rollupOptionsOutput
)?.inlineDynamicImports

if (!inlineDynamic) {
renderChunk(code, chunk, options) {
if (!options.inlineDynamicImports) {
for (const id of chunk.moduleIds) {
const module = this.getModuleInfo(id)
if (!module) continue
Expand Down