Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix svg type override #12078

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 16, 2023

Description

See #12043

Demo: https://stackblitz.com/edit/vitejs-vite-7xwuyv?file=src%2Fmain.ts&terminal=dev

superseds close #12043

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Feb 16, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I tried this before but it didn't work because I'm using /// <reference types="./test.d.ts" /> instead (additional .d.ts part). Looks like omitting it works!

@patak-dev patak-dev merged commit f2a5fcc into vitejs:main Feb 16, 2023
@sapphi-red sapphi-red deleted the docs/fix-svg-type-override branch February 20, 2023 07:12
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants