fix: fix escape character for import.meta.env #11055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
reviewed
Nov 25, 2022
Comment on lines
+49
to
+50
| const envVal = env[key] | ||
| importMetaKeys[`import.meta.env.${key}`] = typeof envVal === 'string' ? `\`${envVal}\`` : JSON.stringify(envVal) |
There was a problem hiding this comment.
I don't think this is the right fix. If the import.meta.env.xxx is in a string, it should be skip entirely, which is being fixed in #9791
|
Closing as this isn't the right fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I find a bug when using import.meta.env:
*.vue?raw will be transformed into
export default "xxxx", if I useimport.meta.env.xxxin a vue component, it will be replaced with "xxx" directly.For example, The source code is
export default "... import.meta.env.xxx === 'dev' ... ", but the final code will beexport default "... "xxx" === 'dev' ... ". The"xxx"should be\"xxx\", or the rollup AST parser will go wrong.I don't know if this is the best solution for this bug, just a suggestion. Maybe the import.meta.env replacement run before *.vue?raw transform will be better?
Forgive me for bad English hhhh.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).