-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: env variables override #10113
fix: env variables override #10113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me with a nit.
Also, I think ignoreProcessEnv should be set to false, as this is very useful in CI builds.
I don't think we'd want to pollute process.env.
for the Vite envs, but perhaps you're referring to #6626 ?
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
fix: #10008
Also, I think
ignoreProcessEnv
should be set to false, as this is very useful in CI builds.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).