Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pnpm shell-emulator instead of cross-env #10023

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

kecrily
Copy link
Contributor

@kecrily kecrily commented Sep 7, 2022

Description

Use pnpm shell-emulator instead of cross-env dependencies

Additional context

pnpm uses @yarnpkg/shell to implement bash-like shell, so cross-env dependencie are no longer needed.

So use the Node glob syntax instead of leaving it to the shell expanded. So use ' wrap glob.

shell-emulator config in PNPM docs


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@kecrily
Copy link
Contributor Author

kecrily commented Sep 7, 2022

I wasn't able to reproduce this CI error in a local approximation.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, thanks for the PR!

Copy link
Contributor

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants