TS errors after switching moduleResolution from Node to Node16 #11552

srflp · 2023-01-01T20:43:25Z

Describe the bug

After changing moduleResolution from Node to Node16 in my tsconfig.json and running tsc in my app, I get plenty of TS errors (pasted below in Logs).

I don't use vite in my project, only vitest but the errors seem to come out of vite and vite-node types.

One way to bypass this issue is to add "skipLibCheck": true to tsconfig.json but it's not a long term solution.

Reproduction

https://github.com/srflp/vite-node16-moduleresolution-type-errors

Steps to reproduce

pnpm install
tsc

System Info

System:
    OS: macOS 13.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 74.13 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.12.1 - ~/.nvm/versions/node/v18.12.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.12.1/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v18.12.1/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Edge: 108.0.1462.54
    Firefox: 108.0.1
    Safari: 16.2

Used Package Manager

pnpm

Logs

➜ tsc -v
Version 4.9.4

➜ tsc

node_modules/.pnpm/vite-node@0.26.3_@types+node@18.11.18/node_modules/vite-node/dist/server.d.ts:1:48 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("vite")' call instead.

1 import { TransformResult, ViteDevServer } from 'vite';
                                                 ~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:7:34 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

7 import { ConnectedPayload } from "../../types/hmrPayload";
                                   ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:8:32 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

8 import { CustomEventMap } from "../../types/customEvent";
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:9:31 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

9 import { CustomPayload } from "../../types/hmrPayload";
                                ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:13:30 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

13 import { ErrorPayload } from "../../types/hmrPayload";
                                ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:20:35 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

20 import { FullReloadPayload } from "../../types/hmrPayload";
                                     ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:21:42 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

21 import { GeneralImportGlobOptions } from "../../types/importGlob";
                                            ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:23:28 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

23 import { HMRPayload } from "../../types/hmrPayload";
                              ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:25:41 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

25 import { ImportGlobEagerFunction } from "../../types/importGlob";
                                           ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:26:36 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

26 import { ImportGlobFunction } from "../../types/importGlob";
                                      ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:27:35 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

27 import { ImportGlobOptions } from "../../types/importGlob";
                                     ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:29:41 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

29 import { InferCustomEventPayload } from "../../types/customEvent";
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:32:35 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

32 import { InvalidatePayload } from "../../types/customEvent";
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:33:32 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

33 import { KnownAsTypeMap } from "../../types/importGlob";
                                  ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:48:30 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

48 import { PrunePayload } from "../../types/hmrPayload";
                                ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:67:24 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

67 import { Update } from "../../types/hmrPayload";
                          ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:68:31 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

68 import { UpdatePayload } from "../../types/hmrPayload";
                                 ~~~~~~~~~~~~~~~~~~~~~~~~


Found 17 errors in 2 files.

Errors  Files
     1  node_modules/.pnpm/vite-node@0.26.3_@types+node@18.11.18/node_modules/vite-node/dist/server.d.ts:1
    16  node_modules/.pnpm/vite@4.0.3_@types+node@18.11.18/node_modules/vite/dist/node/index.d.ts:7

Validations

Follow our Code of Conduct
Read the Contributing Guidelines.
Read the docs.
Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
The provided reproduction is a minimal reproducible example of the bug.

The text was updated successfully, but these errors were encountered:

Maxim-Mazurok · 2023-01-04T02:58:46Z

Same error:

tsc --noEmit        
node_modules/vite-node/dist/server.d.ts:1:48 - error TS1479: The current file is a CommonJS module whose imports 
will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("vite")' call instead.

1 import { TransformResult, ViteDevServer } from 'vite';
                                                 ~~~~~~

node_modules/vite/dist/node/index.d.ts:7:34 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

7 import { ConnectedPayload } from "../../types/hmrPayload";
                                   ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:8:32 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

8 import { CustomEventMap } from "../../types/customEvent";
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:9:31 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

9 import { CustomPayload } from "../../types/hmrPayload";
                                ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:13:30 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

13 import { ErrorPayload } from "../../types/hmrPayload";
                                ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:20:35 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

20 import { FullReloadPayload } from "../../types/hmrPayload";
                                     ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:21:42 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

21 import { GeneralImportGlobOptions } from "../../types/importGlob";
                                            ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:23:28 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

23 import { HMRPayload } from "../../types/hmrPayload";
                              ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:25:41 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

25 import { ImportGlobEagerFunction } from "../../types/importGlob";
                                           ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:26:36 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

26 import { ImportGlobFunction } from "../../types/importGlob";
                                      ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:27:35 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

27 import { ImportGlobOptions } from "../../types/importGlob";
                                     ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:29:41 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

29 import { InferCustomEventPayload } from "../../types/customEvent";
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:32:35 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

32 import { InvalidatePayload } from "../../types/customEvent";
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:33:32 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

33 import { KnownAsTypeMap } from "../../types/importGlob";
                                  ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:48:30 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

48 import { PrunePayload } from "../../types/hmrPayload";
                                ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:67:24 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

67 import { Update } from "../../types/hmrPayload";
                          ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/vite/dist/node/index.d.ts:68:31 - error TS2834: Relative import paths need explicit file extensions 
in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

68 import { UpdatePayload } from "../../types/hmrPayload";
                                 ~~~~~~~~~~~~~~~~~~~~~~~~


Found 17 errors in 2 files.

Errors  Files
     1  node_modules/vite-node/dist/server.d.ts:1
    16  node_modules/vite/dist/node/index.d.ts:7

With tsconfig.json:

{
  "include": ["**/*.ts"],
  "exclude": ["node_modules", "nodeenv"],
  "compilerOptions": {
    "esModuleInterop": true,
    "lib": ["ESNext", "DOM"],
    "module": "ESNext",
    "moduleResolution": "Node16",
    "strict": true,
    "target": "ESNext",
    "types": ["node", "jest"],
    "noErrorTruncation": true,
    "skipLibCheck": false
  },
  "ts-node": {
    "files": true
  }
}

Node v19.3.0
ts-node: 10.9.1
typescript: 4.9.4

See Maxim-Mazurok/vite-ts2834@master...fix for temporary fix using patch-package

ghost · 2023-01-04T19:59:29Z

I have noticed this error as well, I am not saying this is a solution, but for me it seems that commenting this line: "types": ["vitest/globals"] in tsconfig.json fixes the issue, I don't get any error using the globals anyways (even after restarting the TS server.) @Maxim-Mazurok

Maxim-Mazurok · 2023-01-05T01:48:52Z

I have noticed this error as well, I am not saying this is a solution, but for me it seems that commenting this line: "types": ["vitest/globals"] in tsconfig.json fixes the issue, I don't get any error using the globals anyways (even after restarting the TS server.) @Maxim-Mazurok

That's an interesting workaround and it seems to work for me.

Without using "types": ["vitest/globals"] it resolves it/describe/expect to @types/jest from the node_modules of the parent project as I'm using nested monorepo structure. But I'm sure anyone can just install @types/jest into their project.
And then remove all the imports or it/describe/expect/etc. from vitest - this way tsc won't attempt compiling vitest and avoid getting errors.

I'd probably still prefer to use patch for vitest instead of mixing vitest with jest types... And hopefully we'll get a proper fix for this soon.

srflp · 2023-01-05T22:36:58Z

@santimirandarp @Maxim-Mazurok

It's weird, but for me, in my minimal reproduction repo (https://github.com/srflp/vite-node16-moduleresolution-type-errors), adding "types": ["vitest/globals"] in tsconfig.json and removing all vitest imports does not fix anything.

Still the same errors after running tsc.

Could you elaborate more how that fixes the issue for you? 🤔

Maxim-Mazurok · 2023-01-06T02:31:01Z

adding "types": ["vitest/globals"] in tsconfig.json and removing all vitest imports does not fix anything

What @santimirandarp suggested and what I did was to remove vitest/globals, not to add it. In my case, at least, they were replaced by @types/jest.

Anyway, I can't seem to get it working anymore either, might've forgotten to disable the patch last time I was trying.

ghost · 2023-01-08T12:46:37Z

Could you elaborate more how that fixes the issue for you? 🤔

I replied with a code where I dont get errors locally

srflp/vite-node16-moduleresolution-type-errors#1 (comment)

( This is may be a quick workaround but certainly not a solution. )

frank-weindel · 2023-03-02T21:20:45Z

Does Vite just not support Node16 module resolution at this point then?

Maxim-Mazurok · 2023-03-03T22:38:26Z

Does Vite just not support Node16 module resolution at this point then?

Well it works fine with it, but not type-wise, I'm still using the above-mentioned patch Maxim-Mazurok/vite-ts2834@master...fix

Get TypeScript working with the dagre unit test types. Because Typescript's `nodenext` doesn't work well with vitest's types (see vitejs/vite#11552), we need to instead using jest types, which are luckily pretty much exactly the same as vitest's types. TypeScript actually found a minor bug in the `src/dagre/rank/rank.test.js`, which has been in the upstream code since 2014, see https://github.com/dagrejs/dagre/blob/master/test/rank/rank-test.js#L36-L37.

karlhorky · 2023-03-25T17:26:19Z

More details of the broken types for vite and vite/client over here at Are the types wrong? by @andrewbranch:

Imports of "vite" under the node16 module resolution setting when the importing module is CJS (its extension is .cts or .cjs, or it has a .ts or .js extension and is in scope of a package.json that does not contain "type": "module") resolved to ESM types, but CJS implementations.

Imports of multiple entrypoints resolved to ES modules from a CJS importing module. CJS modules in Node will only be able to access this entrypoint with a dynamic import.

DetachHead · 2023-04-14T05:03:43Z

i think the fix is to set "moduleResolution" to "nodenext" in vite's tsconfig, then update all the imports to include explicit file extensions.

andrewbranch · 2023-05-25T22:10:28Z

👋 Hi Vite maintainers, I work on the TypeScript team and am the author of https://arethetypeswrong.github.io that @karlhorky mentioned above. Would you like help solving this issue? I would be happy to discuss solutions, answer questions, or even raise a PR. However, the core team has previously expressed resistance to fixing these issues, so I want to get clarification on whether the team is interested in making Vite APIs compatible with TypeScript before investing time into this.

I really love Vite as a product and would be thrilled to establish a better relationship between our teams and better compatibility between our tools. In the short term though, I just want to type-safely require("vite") in an old CJS project I inherited 😅

What can I do to help?

bluwy · 2023-05-26T03:17:06Z

Hey! We've discussed about this in a team meeting before re require('vite') that we won't be supporting types for it. There was a PR (#10945) that's now closed. The original issue seems to be that vite-node should be using .d.mts instead so TypeScript evaluates it in a ESM context and imports vite transitively as ESM. (Understandably it breaks vite-node CJS types too).

andrewbranch · 2023-05-26T18:45:20Z

Fair enough. In that case, we still need to make a resolution with conditions ["require", "types"] point to the untyped CJS file instead of the ESM typings. Resolving to the ESM typings is misleading and creates incorrect error messages in TS. What a user should see is an error under --noImplicitAny that says the module isn’t typed. They can then ignore the error and work with an any, or enable JS-in-node_modules analysis to possibly get some inferred types, or whatever. What we see instead is a false error that says this require call is going to immediately blow up in Node because it resolves to an ESM file, which isn’t the case.

Secondly, there’s the issue mentioned in the OP. The Node ESM types are invalid because they contain module specifiers that would fail to resolve in Node ESM JS files. The JS files themselves, obviously, are totally fine. So the .d.ts and .js files are very out of sync with each other, which is a situation that is impossible to get into with tsc and seemingly inevitable with Rollup (along with every other TS build tool).

My motivations are twofold: (1) I want the Vite API to be usable for me and for our users, and (2) I want to understand why this is constantly happening. Does Rollup encourage practices that are guaranteed to produce broken types? Would better TS documentation have avoided this issue? Better @rollup/plugin-typescript docs? What made you decide that building your package with tsc isn’t an option? This issue (and this issue tracker in general) may not be the right place for that conversation. I’d be happy to jump on a call or chat in your Discord. It would honestly be a huge help to me to be able to use this as a case study, and maybe I can make it worth your time by fixing this issue along the way 🤞

bluwy · 2023-05-27T07:12:07Z

we still need to make a resolution with conditions ["require", "types"] point to the untyped CJS file instead of the ESM typings

I think I'm fine with that as long as it doesn't break CJS setups. I do like the previous incorrect error have this message though: Consider writing a dynamic 'import("vite")' call instead.

The Node ESM types are invalid because they contain module specifiers that would fail to resolve in Node ESM JS files.

Do you mean the errors for import ... "../../types/hmrPayload"? That isn't really related to Rollup as we intentionally organized it as so. The types directory contains pure .d.ts for two purposes:

Can be extended by users - https://vitejs.dev/guide/api-plugin.html#typescript-for-custom-events
Contains ambient types - https://github.com/vitejs/vite/blob/main/packages/vite/types/importMeta.d.ts

We're also bundling the types with api-extractor (with custom pre/post patch scripts) because we're bundling dependencies (not my decision 😬). But presumably the bigger benefit over tsc in general is that it generates lesser/smaller .d.ts files.

Also I agree that it's slowly going tangent here, happy to continue in https://chat.vitejs.dev (discord)

dargmuesli · 2023-05-29T09:50:00Z

This issue (and this issue tracker in general) may not be the right place for that conversation.

I'm very much interested in the discussion you are having. I think it's great that it's shared here!
You give very interesting insights @andrewbranch and I'm sure there are quite a few people who like to follow along here, silent subscribers :)

- `compilerOptions.skipLibCheck` is set to `true` to get around Vite issues. See vitejs/vite#11552 for details. - `exclude` is set to `["src/**/*.spec.ts", "src/**/*.spec.tsx"]` to get around @testing-library/user-event issues. See https://github.com/testing-library/react-testing-library/issues/1224 for details.

dargmuesli · 2023-08-31T00:41:47Z

Seems like there are good news: in the issue linked above @bluwy said

will likely fix it in the next Vite major.

🥳 just to let folks subscribed to this issue know 😉

vitejs/vite#11552

srflp added the pending triage label Jan 1, 2023

srflp changed the title ~~TS errors after switching to moduleResolution from Node to Node16~~ TS errors after switching moduleResolution from Node to Node16 Jan 1, 2023

Maxim-Mazurok mentioned this issue Jan 4, 2023

error TS2834 when using moduleResolution Node16 vitest-dev/vitest#2606

Closed

6 tasks

rwjblue mentioned this issue Jan 11, 2023

Update vite and vitest to latest data-eden/data-eden#54

Merged

dargmuesli mentioned this issue Apr 19, 2023

refactor(tests): migrate to vitest maevsi/stomper#154

Merged

jmartinezmaes mentioned this issue Apr 22, 2023

Migrate to Vitest for unit testing true-myth/true-myth#530

Merged

andrewbranch mentioned this issue Jun 21, 2023

Duplicated InternalResolutionError arethetypeswrong/arethetypeswrong.github.io#36

Closed

lehni mentioned this issue Jul 25, 2023

v3.0.0 prettier/plugin-pug#458

Merged

Princesseuh mentioned this issue Jul 25, 2023

fix: use file extensions on type imports so they work with moduleResolution: 'node16' #13947

Merged

9 tasks

giancosta86 mentioned this issue Jul 25, 2023

TypeScript compilation error for CommonJS modules rimbu-org/rimbu#175

Closed

bluwy mentioned this issue Aug 17, 2023

publint warnings #14132

Closed

7 tasks

bluwy added this to the 5.0 milestone Aug 17, 2023

gitKrystan added a commit to ember-tooling/prettier-plugin-ember-template-tag that referenced this issue Sep 3, 2023

Ignore vite config TS error

440884e

vitejs/vite#11552

bluwy mentioned this issue Sep 4, 2023

feat!: deprecate cjs node api #14278

Merged

9 tasks

dargmuesli mentioned this issue Sep 6, 2023

refactor(tests): migrate to vitest maevsi/stomper#152

Closed

bluwy closed this as completed in #14278 Sep 21, 2023

github-actions bot locked and limited conversation to collaborators Oct 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TS errors after switching moduleResolution from Node to Node16 #11552

TS errors after switching moduleResolution from Node to Node16 #11552

srflp commented Jan 1, 2023

Maxim-Mazurok commented Jan 4, 2023 •

edited

Loading

ghost commented Jan 4, 2023 •

edited by ghost

Loading

Maxim-Mazurok commented Jan 5, 2023

srflp commented Jan 5, 2023

Maxim-Mazurok commented Jan 6, 2023

ghost commented Jan 8, 2023 •

edited by ghost

Loading

frank-weindel commented Mar 2, 2023

Maxim-Mazurok commented Mar 3, 2023

karlhorky commented Mar 25, 2023 •

edited

Loading

DetachHead commented Apr 14, 2023

andrewbranch commented May 25, 2023 •

edited

Loading

bluwy commented May 26, 2023

andrewbranch commented May 26, 2023

bluwy commented May 27, 2023

dargmuesli commented May 29, 2023

dargmuesli commented Aug 31, 2023

TS errors after switching moduleResolution from Node to Node16 #11552

TS errors after switching moduleResolution from Node to Node16 #11552

Comments

srflp commented Jan 1, 2023

Describe the bug

Reproduction

Steps to reproduce

System Info

Used Package Manager

Logs

Validations

Maxim-Mazurok commented Jan 4, 2023 • edited Loading

ghost commented Jan 4, 2023 • edited by ghost Loading

Maxim-Mazurok commented Jan 5, 2023

srflp commented Jan 5, 2023

Maxim-Mazurok commented Jan 6, 2023

ghost commented Jan 8, 2023 • edited by ghost Loading

frank-weindel commented Mar 2, 2023

Maxim-Mazurok commented Mar 3, 2023

karlhorky commented Mar 25, 2023 • edited Loading

DetachHead commented Apr 14, 2023

andrewbranch commented May 25, 2023 • edited Loading

bluwy commented May 26, 2023

andrewbranch commented May 26, 2023

bluwy commented May 27, 2023

dargmuesli commented May 29, 2023

dargmuesli commented Aug 31, 2023

Maxim-Mazurok commented Jan 4, 2023 •

edited

Loading

ghost commented Jan 4, 2023 •

edited by ghost

Loading

ghost commented Jan 8, 2023 •

edited by ghost

Loading

karlhorky commented Mar 25, 2023 •

edited

Loading

andrewbranch commented May 25, 2023 •

edited

Loading