Wrong envPrefix in Astro Integration

[Eptagone]

Hi, thank you very much for this library.

I'm using the Astro Integration and I discovered that all my PUBLIC_* variables are been ignored after build in my custom service worker.
I tested with the following variables:

PUBLIC_SAMPLE=ASTRO
VITE_SAMPLE=VITE

I saw that the VITE_SAMPLE variable is included but not PUBLIC_SAMPLE.

The default value of envPrefix in Vite is VITE_ but in Astro the prefix is PUBLIC_ for client scripts.

Is there a way to change that?

[userquin]

Only variables starting with VITE_ will be exposed by vite https://vitejs.dev/guide/env-and-mode.html#env-variables-and-modes

To prevent accidentally leaking env variables to the client, only variables prefixed with VITE_ are exposed to your Vite-processed code. e.g. for the following env variables:

VITE_SOME_KEY=123
DB_PASSWORD=foobar

Only VITE_SOME_KEY will be exposed as import.meta.env.VITE_SOME_KEY to your client source code, but DB_PASSWORD will not.

[Eptagone]

That prefix can be customized with the envPrefix option.

https://vitejs.dev/config/shared-options.html#envprefix

[userquin]

Yeah, you can change it, but only those env vars starting with the prefix will be available via import.meta.env.

[userquin]

You can configure empty prefix (vite will thow an error), you will need to use define

[userquin]

Read the SECURITY NOTES from your VITE_ link, you can also use define.

[Eptagone]

Yeah, you can change it, but only those env vars starting with the prefix will be available via import.meta.env.

Yes, that's what I want. I want to make VitePWA to use the same prefix as Astro: PUBLIC_. Because that's the default prefix for client variables in Astro projects.

[Eptagone]

Oops. Sorry, I thought this was a monorepo. I moved this issue to the correct repository.

New in vite-pwa/astro#42