Wrong environment prefix. It should be PUBLIC_ instead of VITE_

[Eptagone]

If you have client environment variables which should be included in the client side scripts, in Astro projects, they should have the prefix PUBLIC_ but if you want to include them in a custom service worker, it won't work because VitePWA is ignoring them.
That's because VitePWA is expecting variables with the prefix VITE_.

The default value for the environment prefix in Vite is VITE_ but in Astro that prefix is PUBLIC_ instead.

[userquin]

can you try changing the vite entry in your astro config file?

vite: {
  envPrefix: 'PUBLIC_'
}

[userquin]

FYI: Astro configuring envPrefix properly:

[userquin]

You cannot access in the client to non PUBLIC_ env variables:

[userquin]

can you provide a minimal repo with the custom sw?

[Eptagone]

can you try changing the vite entry in your astro config file?

vite: {
  envPrefix: 'PUBLIC_'
}

I tried but it didn't work :(

[Eptagone]

can you provide a minimal repo with the custom sw?

Here: https://github.com/Eptagone/astro-vitepwa-envprefix-test

I also discovered a strange thing. The PUBLIC_ are correctly included in development mode. They are only ignored in production (build).

This is a video. In development, it works as expected. The PUBLIC_* variables are read but in production (build) the VITE_* variables are read instead.

BIzqDs9Lpj.mp4

[userquin]

oh wait, you're using custom sw, maybe we need to change the astro pwa integration...

We'll need to include envPrefix here https://github.com/vite-pwa/vite-plugin-pwa/blob/main/src/vite-build.ts#L91-L108 via new option

[userquin]

Local test seems to work, rn only PUBLIC_ working, we need to add the array to make it work with PUBLIC_ and VITE_.

After adding .env and running build with the new vite plugin pwa (PR and release 0.19.6 in a few minutes with pwa astro):

[userquin]

With both entries also working:

[userquin]

tree shaking also working... nice

[userquin]

@Eptagone released 0.3.1 version, this issue should be fixed (your reproduction working)

[Eptagone]

I can confirm that it's working now. Thank very much!