Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the module/library terminology #208

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

bythos14
Copy link
Contributor

@bythos14 bythos14 commented Jun 9, 2022

Deprecates the use of 'modules' in the export configuration.

@d3m3vilurr
Copy link
Contributor

can you explain why do you want to change the name?
(and it need to add into commit message)

@SonicMastr
Copy link

The "module" is the actual PRX itself. A module can have multiple libraries, not the other way around. It's to be consistent with pretty much everything else to avoid confusion

@bythos14
Copy link
Contributor Author

bythos14 commented Jun 9, 2022

As SonicMastr said, consistency. The import configuration yml has the correct use of the 'modules' and 'libraries', this just makes the export configs consistent with that.

It's relevant to issue #48.

@d3m3vilurr
Copy link
Contributor

i got it. so modules of exports.yml have to be just module. but this exports.yml is already a description of the module.
so you use libraries instead of module. right?
(and i checked the imports.yml case, and yes, it was already changed 6yr ago.)

  1. please update commit description about this.
  2. after this pr, we might have to update the specfication document; but only @yifanlu has a source.. :'(

@SonicMastr
Copy link

That is correct

Deprecates the use of 'modules' in export configurations. This is for consistency with import configurations.

See issue vitasdk#48 for more details
@bythos14 bythos14 force-pushed the module-to-library branch from 026d914 to 281d4bc Compare June 9, 2022 17:30
@bythos14
Copy link
Contributor Author

bythos14 commented Jun 9, 2022

@d3m3vilurr I've updated the commit description

@d3m3vilurr d3m3vilurr merged commit da8de85 into vitasdk:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants