Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown backtick background and selection same color #1

Closed
notpeter opened this issue Jan 6, 2025 · 5 comments · Fixed by zed-industries/extensions#1884
Closed

Markdown backtick background and selection same color #1

notpeter opened this issue Jan 6, 2025 · 5 comments · Fixed by zed-industries/extensions#1884
Labels
bug Something isn't working

Comments

@notpeter
Copy link

notpeter commented Jan 6, 2025 •
edited
Loading

Steps to reproduce:

`something`

Select some and it highlights exactly as the rest of the fenced area.

Can you tell which some is selected:

Screenshot 2025-01-06 at 15 45 52

Otherwise nifty theme! I've been using the fact that button background != regular background to identify a bunch of visual jank. Thanks!
@vitallium
Copy link
Owner

Yeah, I noticed that as well and fixed it in 4e13223

CleanShot 2025-01-07 at 22 28 33@2x

@vitallium
Copy link
Owner

I've been using the fact that button background != regular background to identify a bunch of visual jank

This problem is also known, sorry about that. I will address it too.

@notpeter
Copy link
Author

notpeter commented Jan 7, 2025

I've been using the fact that button background != regular background to identify a bunch of visual jank

This problem is also known, sorry about that. I will address it too.

You can do what you want, but I actually like it.
I consider it an accessibility aid as it's crystal clear where the targets are:
Screenshot 2025-01-07 at 16 46 23

@vitallium
Copy link
Owner

I've been using the fact that button background != regular background to identify a bunch of visual jank

This problem is also known, sorry about that. I will address it too.

You can do what you want, but I actually like it. I consider it an accessibility aid as it's crystal clear where the targets are: Screenshot 2025-01-07 at 16 46 23

Thanks! I'm trying to achieve the best with these themes.

@vitallium
Copy link
Owner

Fixed via 4e13223 Thanks for reporting!

@vitallium vitallium added the bug Something isn't working label Jan 9, 2025
@vitallium vitallium mentioned this issue Jan 9, 2025
Merged
notpeter pushed a commit to zed-industries/extensions that referenced this issue Jan 9, 2025
@vitallium
Update Modus Themes to v0.0.5 (#1884)
7daa4a2 
Hi, this PR updates the Modus Themes to v0.0.5 that includes several bug
fixes listed on the release page
[here](https://github.com/vitallium/zed-modus-themes/releases/tag/v0.0.5)
but I am copying them here at your convience:

## Fixed

- [Fix the alpha channel for Drag&Drop
operations](vitallium/zed-modus-themes@d7f097d)
- [Fix the current tab color in Modus Operandi
Tinted](vitallium/zed-modus-themes@316f974)
- Fixed vitallium/zed-modus-themes#1
- [Fix button
background](vitallium/zed-modus-themes@cfe4747)

## Added

- [Add icon
colors](vitallium/zed-modus-themes@508f6ac)


Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Modus Themes to v0.0.5 vitallium/zed-extensions
2 participants
@notpeter @vitallium