Set maximum device problem

[rhenku]

i have small problem, if i set user as manager and set maximum device it work, but if user as manager add user and set maximum devices he can set any number maximum devices.. :D so he can add user and give max number he like..

sory my english bad.. :)

[vitalidze]

This is a known issue and a subject to change in scope of #214.

[wolfbgn]

I dont know if this is the place to mention this. Sorry if I am wrong.
At the moment USER is able to change maximum number of devices and expiration date.
It has to be USER with limited rights not to be able to change these values.
I dont know if I am right but I think that USERS should not be able to change those values.

[vitalidze]

Yeah, I know about this issue. It should be fixed in next version along with #214

[wolfbgn]

Thank you.

[draganjovanovich]

i fixed that by adding this code in userDialog.java and disable ui:field "*****" in xml, i dont know is that correct solution,but it seems to work fine.,. if you want manager to have acces also , just add manager in if statement.

        if (ApplicationContext.getInstance().getUser().getAdmin()) {
            admin.setEnabled(true);
            manager.setEnabled(true);
            readOnly.setEnabled(true);
            expirationDate.setEnabled(true);
            maxNumOfDevices.setEnabled(true);
        }
        else {
            manager.setEnabled(false);
            admin.setEnabled(false);
            readOnly.setEnabled(false);
            expirationDate.setEnabled(false);
            maxNumOfDevices.setEnabled(false);
        } 

[vitalidze]

This fixes it only in UI. You must restrict it on the server side as well (i.e. in DataServiceImpl class).

[draganjovanovich]

Cool, i will do that...

[vitalidze]

You can then submit a pull request to share your solution.

[draganjovanovich]

Ok, tomorrow i will try to change, test it and build.

[vitalidze]

Sounds good. Thank you.

[draganjovanovich]

How to push changes from intellij ?

[vitalidze]

There should be a 'Push changes' item somewhere in 'Git' context menu. You can try searching it in the global search (opened after hitting 'shift shift' (i.e. shift for two times)).

[draganjovanovich]

There is a push ,but it wont push it comes with access denied error.

[vitalidze]

If you have cloned my repository then it won't allow you to push since you don't have access here.

The correct workflow is:

1. fork my repository
2. make a push there
3. create a pull request, so I can merge changes from your repository to mine.

Maybe it looks too complex, but this is the modern way to share your changes on github. I believe it's worth to learn this practice. Anyway, as an option you can just send me changed files by email and I will take it to my repository.

[draganjovanovich]

Now ?

[vitalidze]

It's perfect. Thank you. I will walk through your code and ask you questions directly in #252

[vitalidze]

@wolfbgn now user cannot change neither his expiration date not his maximum number of devices, is is included in 0.8.1rc2

[vitalidze]

Implemented, written news, updated latest and demo versions.