Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict widget size #70

Merged
merged 3 commits into from
Apr 30, 2023
Merged

Restrict widget size #70

merged 3 commits into from
Apr 30, 2023

Conversation

almarklein
Copy link
Member

Closes #62

@almarklein almarklein mentioned this pull request Mar 14, 2023
Closed
@kushalkolar
Copy link
Contributor

Is there a way to make this settable or based on the browser window width/height? We often use 4k screens and have large canvases.

almarklein
almarklein commented Apr 28, 2023
View reviewed changes
@almarklein
Copy link
Member Author

almarklein commented Apr 28, 2023 •
edited
Loading

Good point! I updated the pr.

@almarklein
Copy link
Member Author

Looks like we need to drop Python 3.8. I'm on holiday now, so won't do it now. Though I would merge a PR that fixes that 😉. Otherwise I can fix it later.

@almarklein almarklein merged commit af291c5 into main Apr 30, 2023
@almarklein almarklein deleted the maxheight branch April 30, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kernel dies if widget is resized to a very large height, this sometimes happens unintentionally
2 participants
@almarklein @kushalkolar