Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest jupyterlab-widgets appears to break things #58

Closed
kushalkolar opened this issue Sep 10, 2022 · 4 comments
Closed

latest jupyterlab-widgets appears to break things #58

kushalkolar opened this issue Sep 10, 2022 · 4 comments

Comments

@kushalkolar
Copy link
Contributor

It seems like the latest jupyterlab-widgets released in the past month breaks the working of the remote frame buffer. Running the hello_world example with jupyterlab-widgets v3.0.3 (haven't tested with 3.0.0 - 3.0.2) produces the following when you try to create the output in a jupyter cell.

This issue is not present when using the previous release of jupyterlab-widgets, i.e. v1.1.1, and ipywidgets v7.7.0.

[Open Browser Console for more detailed log - Double click to close this message]
Model class 'RemoteFrameBufferModel' from module 'jupyter_rfb' is loaded but can not be instantiated
TypeError: r._deserialize_state is not a function
    at f._make_model (http://localhost:8891/lab/extensions/@jupyter-widgets/jupyterlab-manager/static/150.3e1e5adfd821b9b96340.js?v=3e1e5adfd821b9b96340:1:7933)

image

@djhoese
Copy link
Member

djhoese commented Sep 12, 2022

Given the version number jump to 3.0 and ipywidgets jumping to 8.0 with major custom widget changes, my guess is that jupyter_rfb is not compatible with these new versions and will require a decent amount of work to get updated. Looking at

https://ipywidgets.readthedocs.io/en/stable/migration_guides.html

It seems the suggestion is to regenerate the entire python package structure from the cookiecutter project. This shouldn't be too big of a deal, but potentially having to rename properties/traits to work with this new version is going to take some time. The lead developer of this project is currently on paternity leave and likely won't have time to update this.

@kushalkolar Do you or someone you know have time to look into updating the library to work with the new versions of the widgets libraries? I think we can focus on dropping support for the older versions if necessary to keep the code cleaner.

@kushalkolar
Copy link
Contributor Author

I could try this out, but I can't provide a timeline. Meanwhile, should jupyter_rfb make a bugfix release? Probably sufficient to change install_requires in setup.py, I can make a PR.

@djhoese
Copy link
Member

djhoese commented Sep 13, 2022

That sounds good to me. I'll have to update the conda-forge recipe too after that release, but that's not too bad.

almarklein pushed a commit that referenced this issue Sep 29, 2022
* temporary fix for #58, use jupyter-widgets==1.1.1, ipywidgets<8, update version to 0.3.2

* less strict jupyterlab-widgets version
@almarklein
Copy link
Member

Closed by #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants