Adding 1-dimensional version of RationalQuadraticSpline and tests for conditional blocks #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RussellALA
commented
Feb 21, 2023
- Added new InvertibleModule RationalQuadraticSplines_1D that can be used as invertible learnable transform when couplings are not desirable (e.g. when the feature dimension is 1).
- Restructured the BinnedSpline class s.t. it works as an InvertibleModule instead of a Coupling
- Added BinnedSplineCoupling class to replace the old BinnedSpline
- Added conditional SequenceINN tests in spline_tests.py
…rk tests to spline_tests.py
… Split module sections_sizes
fdraxler
reviewed
Mar 2, 2023
| @@ -44,6 +45,65 @@ def _spline2(self, x: torch.Tensor, parameters: Dict[str, torch.Tensor], rev: bo | |||
| return rational_quadratic_spline(x, left, right, bottom, top, deltas_left, deltas_right, rev=rev) | |||
|
|
|||
|
|
|||
| class RationalQuadraticSpline_1D(BinnedSpline): | |||
There was a problem hiding this comment.
I think the name might be misleading… 1D suggests that one only can have 1D transformations, but this is not the case
There was a problem hiding this comment.
Renamed to ElementwiseRationalQuadraticSpline
…ine. Renamed BinnedSplineCoupling to BinnedSpline for backwards compatability. Renamed existing BinnedSpline to BinnedSplineBase
LarsKue
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Code looks good. I like the restructured BinnedSpline. Might be worth looking into refactoring the overall structure of InvertibleModule vs Coupling in general (including the file structure). But I think we should relay that to the future and merge this as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.