-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequential selection feat #73
Conversation
I don't understand this feature. Can you please elaborate? |
@yotamberk This feature does not allow the user to select multiple items that are not sequential. This is a use case for when the user should not have time gaps in the items they select. In the demo, turn Then turn |
Ok, I understand now. |
I have a use case where the user should not be allowed to have gaps in the items they select. |
Please explain. |
Each item represents a task but my API only allows a user to take actions on a group of tasks where each task happens right after another. If a user were to try to take action on a group of tasks that are not next to each other, my API wouldn't process the request. So the user could go without this feature but would get confused when nothing happens to try to process non-sequential tasks. This is more of a user experience design with only processing one block of tasks at a time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is really hard to understand!
I played around with your Demo using shift
and ctrl
. I think this is a nice addition. Probably this will not be used often but for some power user it might be an important addition.
@jczacharia Nice work! Example, docs, everything very nice! 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @mojoaxel . This is not a clear feature and it will probably be very rarely used, but I will approve it for the odd times people do want to need this feature.
Good work! Really!
The PR adds the feature: Allow only sequential selection of items when
sequentialSelection: true
of the timeline's configuration options.Demo: https://next.plnkr.co/edit/2EUet6TcIoHGcH6G