FIX #46 to ensure that the width constraint is being applied with lab… #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplied with labels that are correctly measured
…ulp-version-for-travis specify gulp@3.9.1 in travis config
|
hi @channeladam like with the other ones, when you have a moment, could you rebase this branch with master to bring in the fix for travis? full instructions here in case they are helpful 😄 #43 (comment) |
|
thanks for specifying the example to use to test this out, that is helpful! |
…pplied with labels that are correctly measured
…m/visjs-network into fix-label-measurement
micahstubbs
reviewed
Jan 27, 2019
| // Set the canvas context font, based upon the current selected/hover state | ||
| // and the provided mod, so the text measurement performed by getLongestFit | ||
| // will be accurate - and not just use the font of whoever last used the canvas. | ||
| this.parent.getFormattingValues(this.ctx, this.selected, this.hover, mod) |
There was a problem hiding this comment.
thanks for including the code comments!
This was referenced Jul 26, 2019
|
💌 Thanks @channeladam for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #46
See manual test html file /test/network/textMeasurementOnHoverTest.html